Fix build/mac/tweak_app_infoplist build script for git users

Fix build/mac/tweak_app_infoplist build script for git users

r23075

[Mark Mentovai, 2009-08-11 20:08:31]

http://codereview.chromium.org/165314/diff/1/2
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/165314/diff/1/2#newcode79
Line 79: | sed -Ene 's/^git-svn-id: (.*)@([0-9]*)(.*)$/\2/p')
Indent a continuation line by 4, not 2, spaces.

The sed script should be:

sed -Ene 's/^git-svn-id: .*@([0-9]+).*$/\1/p'

You don't need to have the .* in (match groups), and you should use + to match
one or more digit.

http://codereview.chromium.org/165314/diff/1/2#newcode86
Line 86: | sed -Ene "s/^git-svn-id: ${SVN_BASE}(.*)@(.*)$/\1/p")
Same comment about indenting your continuation line.

We actualy don't want to look for SVN_BASE by the full URL, because people might
be using different servers.  I think we just want to look for /chrome/.  Also,
you can clean your sed script up in terms of escaping the slashes if you use an
alternate delimiter.  I usually use % when I want to use slashes in the script. 
This is what we should wind up with:

sed -Ene 's%^git-svn-id: .*/chrome/(.*)@.*$%/\1%p'

Note that the replacement pattern is /\1.  This is to get the slash that we're
taking off of /chrome/ back on there.  This will match what we've done with "svn
info" - we want the path to come out looking like "/trunk/src" or
"/branches/198.0/src".

[---DO NOT USE---rsesek, 2009-08-11 20:18:26]

http://codereview.chromium.org/165314/diff/1/2
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/165314/diff/1/2#newcode79
Line 79: | sed -Ene 's/^git-svn-id: (.*)@([0-9]*)(.*)$/\2/p')
On 2009/08/11 20:08:31, Mark Mentovai wrote:
> Indent a continuation line by 4, not 2, spaces.
> 
> The sed script should be:
> 
> sed -Ene 's/^git-svn-id: .*@([0-9]+).*$/\1/p'
> 
> You don't need to have the .* in (match groups), and you should use + to match
> one or more digit.

Done.

http://codereview.chromium.org/165314/diff/1/2#newcode86
Line 86: | sed -Ene "s/^git-svn-id: ${SVN_BASE}(.*)@(.*)$/\1/p")
On 2009/08/11 20:08:31, Mark Mentovai wrote:
> Same comment about indenting your continuation line.
> 
> We actualy don't want to look for SVN_BASE by the full URL, because people
might
> be using different servers.  I think we just want to look for /chrome/.  Also,
> you can clean your sed script up in terms of escaping the slashes if you use
an
> alternate delimiter.  I usually use % when I want to use slashes in the
script. 
> This is what we should wind up with:
> 
> sed -Ene 's%^git-svn-id: .*/chrome/(.*)@.*$%/\1%p'
> 
> Note that the replacement pattern is /\1.  This is to get the slash that we're
> taking off of /chrome/ back on there.  This will match what we've done with
"svn
> info" - we want the path to come out looking like "/trunk/src" or
> "/branches/198.0/src".

Done.

[Mark Mentovai, 2009-08-11 20:20:20]

LGTM