Add a first attempt at a compact location bar and a status bar. The status ba...

Add a first attempt at a compact location bar and a status bar. The status bar
contains a clock, an application menu, and a non-working battery indicator.
The compact location bar can be toggled by COMPACT_NAV_BAR in browser_window_gtk.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23070

[sky, 2009-08-11 04:30:03]

http://codereview.chromium.org/165272/diff/1091/95
File chrome/browser/defaults.cc (right):

http://codereview.chromium.org/165272/diff/1091/95#newcode25
Line 25: // On Windows, popup windows' autocomplete box have a font 5/6 the size
of a
nit: could you make this comment say you're duplicating the windows behavior.

http://codereview.chromium.org/165272/diff/1091/88
File chrome/browser/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/165272/diff/1091/88#newcode395
Line 395: compact_navigation_bar_(NULL),
could you null out status_area_ too. It doesn't look it is always created.

http://codereview.chromium.org/165272/diff/1091/88#newcode1400
Line 1400: // realize (requiring a window) in the Init function).
nit: nuke the last )

http://codereview.chromium.org/165272/diff/1091/98
File chrome/browser/views/compact_navigation_bar.cc (right):

http://codereview.chromium.org/165272/diff/1091/98#newcode18
Line 18: 
nit: nuke one of these lines.

http://codereview.chromium.org/165272/diff/1091/98#newcode89
Line 89: width += forward_button_->GetPreferredSize().width() + kHorizPadding;
I think you need to add kInnerPadding * 2 to each of the button sizes, as you do
that in the layout code.

http://codereview.chromium.org/165272/diff/1091/98#newcode102
Line 102: curx += height() + kHorizPadding;
height() -> 25, and make 25 a constant as you use it in a number of places.

http://codereview.chromium.org/165272/diff/1091/98#newcode129
Line 129: canvas->TileImageInt(*background, 0, 0, width(), height());
Does this need to go through some theme manager or something?

http://codereview.chromium.org/165272/diff/1091/98#newcode137
Line 137: if (sender == chrome_button_) {
NOTIMPLEMENTED?TODO?

http://codereview.chromium.org/165272/diff/1091/99
File chrome/browser/views/compact_navigation_bar.h (right):

http://codereview.chromium.org/165272/diff/1091/99#newcode31
Line 31: CompactNavigationBar(Browser* browser);
explicit

http://codereview.chromium.org/165272/diff/1091/91
File chrome/browser/views/frame/status_area_view.cc (right):

http://codereview.chromium.org/165272/diff/1091/91#newcode174
Line 174: canvas->TileImageInt(*background, 0, 0, width(), height());
Do you need anything for themes?

http://codereview.chromium.org/165272/diff/1091/92
File chrome/browser/views/frame/status_area_view.h (right):

http://codereview.chromium.org/165272/diff/1091/92#newcode5
Line 5: #ifndef CHROME_BROWSER_VIEWS_FRAME_STATUS_AREA_H_
nit: STATUS_AREA_VIEW

http://codereview.chromium.org/165272/diff/1091/92#newcode18
Line 18: class SimpleMenuModel;
you can nuke this declaration as you're including the header.

[brettw, 2009-08-11 17:17:50]

Comments should be addressed.

[sky, 2009-08-11 17:41:08]

LGTM