Issue 165174: Try again: Check blockfile size before attempting to read the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165174: Try again: Check blockfile size before attempting to read the header. (Closed)

Created:
11 years, 4 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Try again: Check blockfile size before attempting to read the header. Reading past the last page of a mmapped file will SIGBUS. BUG=18174 TEST=truncate Default/Cache/data_* to zero bytes, launch chrome, try to load a website. It shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22843

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -18 lines)			Patch
M	net/disk_cache/block_files.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/disk_cache/block_files.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/disk_cache/block_files_unittest.cc	View	6 chunks	+44 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

Had to close the file before truncating it to make windows happy.

11 years, 4 months ago (2009-08-07 22:38:18 UTC) #1

OK

Expand Messages | Collapse Messages