Issue 165165: Linux: fix jump jump based on uninitialised value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165165: Linux: fix jump jump based on uninitialised value. (Closed)

Created:
11 years, 4 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: fix jump jump based on uninitialised value. This is causing layout test flakiness and a curious effect where text seems to twitch back and forth randomly. I'm not at all sure about this fix. I'll send it upstream for review, but I want to get it fixed locally first because it's causing problems for us.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	third_party/harfbuzz/src/harfbuzz-hebrew.c	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	third_party/harfbuzz/src/harfbuzz-shaper.cpp	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages