Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 165085: Define _FILE_OFFSET_BITS=64 in order to support large files (>2GB).... (Closed)

Created:
11 years, 4 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
vandebo.gmail
CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw
Visibility:
Public.

Description

Define _FILE_OFFSET_BITS=64 in order to support large files (>2GB). _FILE_OFFSET_BITS=64 is incompatible with fts (issue 17492), so file_util::Delete, file_util::CopyDirectory file_util::FileEnumerator are reimplemented without fts. Delete and CopyDirectory are now implemented using FileEnumerator. Patch from vandebo@google.com, original review: http://codereview.chromium.org/160479 BUG=13718, 17492 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -277 lines) Patch
M base/file_util.h View 3 chunks +21 lines, -5 lines 0 comments Download
M base/file_util_posix.cc View 8 chunks +173 lines, -201 lines 0 comments Download
M base/test_file_util_posix.cc View 3 chunks +53 lines, -71 lines 0 comments Download
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Lei Zhang
11 years, 4 months ago (2009-08-06 21:08:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698