Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 165064: IPC tests were moved from unit_tests to ipc_tests, so... (Closed)

Created:
11 years, 4 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
Michael Moss
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Erik does not do reviews, dank, the_wrong_timurrrr, stuartmorgan
Visibility:
Public.

Description

r21342 moved IPC tests from unit_tests to ipc_tests, so tell chrome_tests.py to look in ipc rather than chrome for its gtest.txt file, and actually move it. (At least for valgrind. Purify may need the same change.) Disable IPCChannelTest.ChannelTest and VisitedLinkEventsTest.Coalescense on valgrind, as they hang there today on linux bots. BUG=22141, 22146 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26453

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
D chrome/test/data/valgrind/unit_tests.gtest.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A ipc/data/valgrind/ipc_tests.gtest.txt View 3 1 chunk +4 lines, -0 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dank
Care to approve a little move? Timur noticed this, I added the purify part.
11 years, 4 months ago (2009-08-06 17:58:31 UTC) #1
Erik does not do reviews
LGTM The ipc_tests used to have a problem where they were hanging at process exit. ...
11 years, 4 months ago (2009-08-13 23:49:08 UTC) #2
dank
This was partly approved by erik last month, but I changed it a bit today ...
11 years, 3 months ago (2009-09-17 17:07:41 UTC) #3
Michael Moss
11 years, 3 months ago (2009-09-17 17:17:28 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698