Add support for (some) assignment expressions to the CFG builder and...

src/ia32/cfg-ia32.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 103 matching lines @@
 
 
 void PositionInstr::Compile(MacroAssembler* masm) {
   if (FLAG_debug_info && pos_ != RelocInfo::kNoPosition) {
     __ RecordStatementPosition(pos_);
     __ RecordPosition(pos_);
   }
 }
 
 
+void MoveInstr::Compile(MacroAssembler* masm) {
+  location()->Move(masm, value());
+}
+
+
 void BinaryOpInstr::Compile(MacroAssembler* masm) {
   // The right-hand value should not be on the stack---if it is a
   // compiler-generated temporary it is in the accumulator.
-  ASSERT(!val1_->is_on_stack());
+  ASSERT(!value1()->is_on_stack());
 
   Comment cmnt(masm, "[ BinaryOpInstr");
   // We can overwrite one of the operands if it is a temporary.
   OverwriteMode mode = NO_OVERWRITE;
-  if (val0_->is_temporary()) {
+  if (value0()->is_temporary()) {
     mode = OVERWRITE_LEFT;
-  } else if (val1_->is_temporary()) {
+  } else if (value1()->is_temporary()) {
     mode = OVERWRITE_RIGHT;
   }
 
   // Push both operands and call the specialized stub.
-  if (!val0_->is_on_stack()) {
-    val0_->Push(masm);
+  if (!value0()->is_on_stack()) {
+    value0()->Push(masm);
   }
-  val1_->Push(masm);
-  GenericBinaryOpStub stub(op_, mode, SMI_CODE_IN_STUB);
+  value1()->Push(masm);
+  GenericBinaryOpStub stub(op(), mode, SMI_CODE_IN_STUB);
   __ CallStub(&stub);
-  loc_->Set(masm, eax);
+  location()->Set(masm, eax);
 }
 
 
 void ReturnInstr::Compile(MacroAssembler* masm) {
   // The location should be 'Effect'.  As a side effect, move the value to
   // the accumulator.
   Comment cmnt(masm, "[ ReturnInstr");
   value_->Get(masm, eax);
 }
 
@@ skipping 18 matching lines @@
       const int kOffset = JavaScriptFrameConstants::kLocal0Offset;
       return Operand(ebp, kOffset - loc->index() * kPointerSize);
     }
     default:
       UNREACHABLE();
       return Operand(eax);
   }
 }
 
 
+void Constant::MoveToSlot(MacroAssembler* masm, SlotLocation* loc) {
+  __ mov(ToOperand(loc), Immediate(handle_));
+}
+
+
 void SlotLocation::Get(MacroAssembler* masm, Register reg) {
   __ mov(reg, ToOperand(this));
 }
 
 
 void SlotLocation::Set(MacroAssembler* masm, Register reg) {
   __ mov(ToOperand(this), reg);
 }
 
 
 void SlotLocation::Push(MacroAssembler* masm) {
   __ push(ToOperand(this));
 }
 
 
+void SlotLocation::Move(MacroAssembler* masm, Value* value) {
+  // We dispatch to the value because in some cases (temp or constant)
+  // we can use a single instruction.
+  value->MoveToSlot(masm, this);
+}
+
+void SlotLocation::MoveToSlot(MacroAssembler* masm, SlotLocation* loc) {
+  // The accumulator is not live across a MoveInstr.
+  __ mov(eax, ToOperand(this));
+  __ mov(ToOperand(loc), eax);
+}
+
+
 void TempLocation::Get(MacroAssembler* masm, Register reg) {
   switch (where_) {
     case ACCUMULATOR:
       if (!reg.is(eax)) __ mov(reg, eax);
       break;
     case STACK:
       __ pop(reg);
       break;
-    case NOWHERE:
+    case NOT_ALLOCATED:
       UNREACHABLE();
-      break;
   }
 }
 
 
 void TempLocation::Set(MacroAssembler* masm, Register reg) {
   switch (where_) {
     case ACCUMULATOR:
       if (!reg.is(eax)) __ mov(eax, reg);
       break;
     case STACK:
       __ push(reg);
       break;
-    case NOWHERE:
+    case NOT_ALLOCATED:
       UNREACHABLE();
-      break;
   }
 }
 
 
 void TempLocation::Push(MacroAssembler* masm) {
   switch (where_) {
     case ACCUMULATOR:
       __ push(eax);
       break;
     case STACK:
-    case NOWHERE:
+    case NOT_ALLOCATED:
       UNREACHABLE();
+  }
+}
+
+
+void TempLocation::Move(MacroAssembler* masm, Value* value) {
+  switch (where_) {
+    case ACCUMULATOR:
+      value->Get(masm, eax);
       break;
+    case STACK:
+      value->Push(masm);
+      break;
+    case NOT_ALLOCATED:
+      UNREACHABLE();
+  }
+}
+
+
+void TempLocation::MoveToSlot(MacroAssembler* masm, SlotLocation* loc) {
+  switch (where_) {
+    case ACCUMULATOR:
+      __ mov(ToOperand(loc), eax);
+      break;
+    case STACK:
+      __ pop(ToOperand(loc));
+      break;
+    case NOT_ALLOCATED:
+      UNREACHABLE();
   }
 }
 
 
 #undef __
 
 } }  // namespace v8::internal