Issue 165044: API: added function to find instance of template in prototype chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165044: API: added function to find instance of template in prototype chain. (Closed)

Created:
11 years, 4 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

API: added function to find instance of template in prototype chain. Also inlined Object::IsInstanceOf. This new function is intended to be used to speed up DOM bindings.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes. #

Patch Set 3 : Extended a comment. #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -19 lines)			Patch
M	include/v8.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	2	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

I think you should add some test cases to test-api.cc. Other than that, the change ...

11 years, 4 months ago (2009-08-06 09:59:52 UTC) #2

Vitaly Repeshko

I added a test. Also I reworked the function to use JSObject-s only. Please take ...

11 years, 4 months ago (2009-08-06 13:02:19 UTC) #3

LGTM.

Expand Messages | Collapse Messages