Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.h

Issue 165043: X64: Fix bug in boolean conversion of empty string. (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4020 matching lines...) Expand 10 before | Expand all | Expand 10 after
4031 4031
4032 // Casting. 4032 // Casting.
4033 static inline SlicedString* cast(Object* obj); 4033 static inline SlicedString* cast(Object* obj);
4034 4034
4035 // Garbage collection support. 4035 // Garbage collection support.
4036 void SlicedStringIterateBody(ObjectVisitor* v); 4036 void SlicedStringIterateBody(ObjectVisitor* v);
4037 4037
4038 // Layout description 4038 // Layout description
4039 #if V8_HOST_ARCH_64_BIT 4039 #if V8_HOST_ARCH_64_BIT
4040 // Optimizations expect buffer to be located at same offset as a ConsString's 4040 // Optimizations expect buffer to be located at same offset as a ConsString's
4041 // first substring. In 64 bit mode we have room for the size before the 4041 // first substring. In 64 bit mode we have room for the start offset before
4042 // buffer. 4042 // the buffer.
4043 static const int kStartOffset = String::kSize; 4043 static const int kStartOffset = String::kSize;
4044 static const int kBufferOffset = kStartOffset + kIntSize; 4044 static const int kBufferOffset = kStartOffset + kIntSize;
4045 static const int kSize = kBufferOffset + kPointerSize; 4045 static const int kSize = kBufferOffset + kPointerSize;
4046 #else 4046 #else
4047 static const int kBufferOffset = String::kSize; 4047 static const int kBufferOffset = String::kSize;
4048 static const int kStartOffset = kBufferOffset + kPointerSize; 4048 static const int kStartOffset = kBufferOffset + kPointerSize;
4049 static const int kSize = kStartOffset + kIntSize; 4049 static const int kSize = kStartOffset + kIntSize;
4050 #endif 4050 #endif
4051 4051
4052 // Support for StringInputBuffer. 4052 // Support for StringInputBuffer.
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
4789 } else { 4789 } else {
4790 value &= ~(1 << bit_position); 4790 value &= ~(1 << bit_position);
4791 } 4791 }
4792 return value; 4792 return value;
4793 } 4793 }
4794 }; 4794 };
4795 4795
4796 } } // namespace v8::internal 4796 } } // namespace v8::internal
4797 4797
4798 #endif // V8_OBJECTS_H_ 4798 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698