Issue 165016: Linux: add GYP flag to build with system libbz2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165016: Linux: add GYP flag to build with system libbz2. (Closed)

Created:
11 years, 4 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: add GYP flag to build with system libbz2. This follows the general style of r21663, which we agreed was the way to do this. Note that, currently, one cannot build with system libbz2 on a 64-bit system since it's not part of the ia32-compat package.

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -33 lines)			Patch
M	chrome/browser/metrics/metrics_service.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/common/bzip2_unittest.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	net/base/bzip2_filter.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	net/base/bzip2_filter_unittest.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	third_party/bzip2/bzip2.gyp	View	1 chunk	+54 lines, -29 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 4 months ago (2009-08-05 22:54:49 UTC) #2

LGTM if you check the below issue is ok

http://codereview.chromium.org/165016/diff/1/6
File third_party/bzip2/bzip2.gyp (right):

http://codereview.chromium.org/165016/diff/1/6#newcode49
Line 49: 'type': '<(library)',
This might need to be type "none", so that dependent libraries don't attempt to
add -lbzip2 (the target name) to the link line.  Grep the other gyp files for
other examples.

Expand Messages | Collapse Messages