Issue 1650011: Port inlining of type checks in call ICs for API functions to x64 and arm (is...

Issue 1650011: Port inlining of type checks in call ICs for API functions to x64 and arm (is... (Closed)

Created:
10 years, 8 months ago by podivilov

Modified:
9 years, 4 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port inlining of type checks in call ICs for API functions to x64 and arm (issue 602, r3825). Commited: http://code.google.com/p/v8/source/detail?r=4540

Patch Set 3 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+716 lines, -255 lines)			Patch
M	src/arm/macro-assembler-arm.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		4 chunks	+11 lines, -2 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 2	6 chunks	+300 lines, -85 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+0 lines, -101 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+49 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View		1 chunk	+67 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		4 chunks	+11 lines, -2 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2	7 chunks	+266 lines, -63 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

LGTM. http://codereview.chromium.org/1650011/diff/12001/13005 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/1650011/diff/12001/13005#newcode600 src/x64/stub-cache-x64.cc:600: // -- rsp[16] : api call data nit: ...

10 years, 8 months ago (2010-04-17 01:08:09 UTC) #2

Vitaly Repeshko

http://codereview.chromium.org/1650011/diff/12001/13008 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/1650011/diff/12001/13008#newcode652 src/arm/stub-cache-arm.cc:652: __ stm(ia, sp, r5.bit() | r6.bit() | r7.bit()); Will ...

10 years, 8 months ago (2010-04-17 01:10:34 UTC) #3

podivilov

10 years, 8 months ago (2010-04-19 13:23:08 UTC) #4

http://codereview.chromium.org/1650011/diff/12001/13008
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/1650011/diff/12001/13008#newcode652
src/arm/stub-cache-arm.cc:652: __ stm(ia, sp, r5.bit() | r6.bit() | r7.bit());
I've thought about it, but using stm with increment before mode results in
"Fatal error in , line 0  unimplemented code". May it be just a problem with
simulator?

On 2010/04/17 01:10:34, Vitaly wrote:
> Will "ib" work here?

http://codereview.chromium.org/1650011/diff/12001/13005
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/1650011/diff/12001/13005#newcode600
src/x64/stub-cache-x64.cc:600: //  -- rsp[16]              : api call data
On 2010/04/17 01:08:09, Vitaly wrote:
> nit: Align ":".

Done.

http://codereview.chromium.org/1650011/diff/12001/13005#newcode991
src/x64/stub-cache-x64.cc:991: Label miss_if_smi_check;
On 2010/04/17 01:08:09, Vitaly wrote:
> Typo: miss_if_smi_check -> miss_in_smi_check.

Done.

Expand Messages | Collapse Messages