Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1650006: Unify metrics_collection and metrics_daemon into metrics. (Closed)

Created:
10 years, 8 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Luigi Semenzato, sosa
Visibility:
Public.

Description

Unify metrics_collection and metrics_daemon into metrics. Tested new binaries on the target. Tested incremental build. Tested arm-generic build.

Patch Set 1 #

Patch Set 2 : PTAL -- further cleanup based on the ebuild cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -112 lines) Patch
A src/platform/metrics/Makefile View 1 1 chunk +91 lines, -0 lines 0 comments Download
A src/platform/metrics/README View 1 chunk +8 lines, -0 lines 0 comments Download
A + src/platform/metrics/marshal_void__string_boxed.list View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/metrics/metrics_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/platform/metrics/metrics_daemon.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/metrics/metrics_daemon.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + src/platform/metrics/metrics_daemon_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/platform/metrics/metrics_daemon_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/metrics/metrics_library.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/metrics/metrics_library.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/platform/metrics/network_states.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/metrics/syslog_parser.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/platform/metrics_collection/Makefile View 1 chunk +0 lines, -41 lines 0 comments Download
D src/platform/metrics_collection/README View 1 chunk +0 lines, -3 lines 0 comments Download
D src/platform/metrics_collection/omaha_tracker.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/platform/metrics_daemon/Makefile View 1 chunk +0 lines, -66 lines 0 comments Download
D src/platform/metrics_daemon/README View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
petkov
I'll add an empty omaha_tracker.sh when I push this CL. git cl upload doesn't allow ...
10 years, 8 months ago (2010-04-14 17:41:00 UTC) #1
sosa
lgtm
10 years, 8 months ago (2010-04-14 17:45:56 UTC) #2
petkov
10 years, 8 months ago (2010-04-14 19:56:07 UTC) #3
PTAL -- cleanup based on the ebuild cleanup.

Powered by Google App Engine
This is Rietveld 408576698