Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: src/platform/metrics/metrics_library.h

Issue 1649007: metrics cleanup and fixes. (Closed)
Patch Set: Expose the pass/fail status. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform/metrics/metrics_daemon.cc ('k') | src/platform/metrics/metrics_library.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/metrics/metrics_library.h
diff --git a/src/platform/metrics/metrics_library.h b/src/platform/metrics/metrics_library.h
index f1268c971c925c96bee8da58917a5edadd28a80c..ebc972cae4b897f193d80ee4e0b9897f887c7727 100644
--- a/src/platform/metrics/metrics_library.h
+++ b/src/platform/metrics/metrics_library.h
@@ -12,7 +12,6 @@
#ifndef METRICS_LIBRARY_H_
#define METRICS_LIBRARY_H_
-#include <stdio.h>
#include <string>
// TODO(sosa@chromium.org): Add testing for send methods
@@ -20,14 +19,10 @@
// Library used to send metrics both Autotest and Chrome
class MetricsLibrary {
public:
- // Sends histogram data to Chrome.
- static void SendToChrome(std::string name, std::string value);
- // Sends to Autotest.
- static void SendToAutotest(std::string name, std::string value);
-
- private:
- // Prints message to stderr
- static void PrintError(const char *message, const char *file, int code);
+ // Sends histogram data to Chrome and returns true on success.
+ static bool SendToChrome(std::string name, int value);
+ // Sends to Autotest and returns true on success.
+ static bool SendToAutotest(std::string name, int value);
};
#endif /* METRICS_LIBRARY_H_ */
« no previous file with comments | « src/platform/metrics/metrics_daemon.cc ('k') | src/platform/metrics/metrics_library.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698