Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 16483: Update some of the mac specific entries. (Closed)

Created:
11 years, 12 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update some of the mac specific entries. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7488

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M webkit/tools/layout_tests/test_lists/tests_fixable.txt View 8 chunks +3 lines, -15 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
TVL
11 years, 12 months ago (2008-12-29 21:07:13 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/16483/diff/1/2 File webkit/tools/layout_tests/test_lists/tests_fixable.txt (right): http://codereview.chromium.org/16483/diff/1/2#newcode1587 Line 1587: // passing as of 12/29/08 MAC : LayoutTests/http/tests/security/cross-frame-access-call.html ...
11 years, 12 months ago (2008-12-29 21:11:41 UTC) #2
TVL
http://codereview.chromium.org/16483/diff/1/2 File webkit/tools/layout_tests/test_lists/tests_fixable.txt (right): http://codereview.chromium.org/16483/diff/1/2#newcode1587 Line 1587: // passing as of 12/29/08 MAC : LayoutTests/http/tests/security/cross-frame-access-call.html ...
11 years, 12 months ago (2008-12-29 21:15:08 UTC) #3
Avi (use Gerrit)
11 years, 12 months ago (2008-12-29 21:17:57 UTC) #4
On 2008/12/29 21:15:08, thomasvl wrote:
> The timeout ones have been flaky in the past, so I was leaving it so it would
be
> easier to see that it was flaky in the past.

That sounds good. LGTM if you update the comment with a note explaining it (e.g.
"this was flaky but it seems to have stabilized; remove if it proves itself")

Powered by Google App Engine
This is Rietveld 408576698