Refactor the render widget unittest so it can be reused to create a render vi...

Refactor the render widget unittest so it can be reused to create a render view
unit test. Change the mock render thread to save all IPC messages it is asked to
send so that tests can verify that the correct ones were sent. There are some
new functions that support this checking.

Plumb the form state change notification through the render view so that we
will correctly update the form state to the browser.

Write two RenderView unit tests. One arbitrarily tests OnLoadAlternateHTMLText
which I used as a testcase for my testing framework. The other tests the above
form state change notification. I had to expose the timeout of this message
through the RenderView API so that the test can change it.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7549

[rvargas (doing something else), 2008-12-29 19:22:56]

There are a few lint errors. If using_npapi is not intentional, looks good after
removing it.

http://codereview.chromium.org/16482/diff/203/204
File chrome/test/unit/unittests.vcproj (right):

http://codereview.chromium.org/16482/diff/203/204#newcode20
Line 20:
InheritedPropertySheets="$(SolutionDir)..\build\common.vsprops;$(SolutionDir)..\build\debug.vsprops;..\..\tools\build\win\precompiled_wtl.vsprops;..\..\tools\build\win\unit_test.vsprops;$(SolutionDir)..\third_party\libpng\using_libpng.vsprops;$(SolutionDir)..\third_party\zlib\using_zlib.vsprops;$(SolutionDir)..\skia\using_skia.vsprops;$(SolutionDir)..\third_party\libxml\build\using_libxml.vsprops;$(SolutionDir)..\third_party\icu38\build\using_icu.vsprops;$(SolutionDir)..\testing\using_gtest.vsprops;..\..\third_party\hunspell\using_hunspell.vsprops;..\..\..\third_party\npapi\using_npapi.vsprops"
Is Adding a dependency on using_npapi.vsprops intentional?

[brettw, 2008-12-31 00:23:50]

I was doing the rest of my form state changes as a separate patch, but I forgot
to submit this one, and things got all tangled. So this latest patch now
includes hooking up the form state notifications and the corresponding unit
tests.

You can diff versus patch set 2 to see the new parts. Sorry about this.

[rvargas (doing something else), 2008-12-31 02:09:29]

Nice overall. Just a few comments.

http://codereview.chromium.org/16482/diff/19/604
File chrome/renderer/mock_render_thread.h (right):

http://codereview.chromium.org/16482/diff/19/604#newcode10
Line 10: #include "base/linked_ptr.h"
I guess this is not used?

http://codereview.chromium.org/16482/diff/19/604#newcode22
Line 22: typedef std::pair<IPC::Message, char*> MessagePair;
To reduce noise in purify we should probably change char* to an object that gets
deleted with the container.

http://codereview.chromium.org/16482/diff/19/617
File chrome/renderer/render_view.h (right):

http://codereview.chromium.org/16482/diff/19/617#newcode323
Line 323: RenderView(RenderThreadBase* render_thread);
nit: should be explicit

http://codereview.chromium.org/16482/diff/19/602
File chrome/test/unit/unittests.vcproj (right):

http://codereview.chromium.org/16482/diff/19/602#newcode301
Line 301: XMLDocumentationFileName="$(IntDir)\$(InputName)1.xdc"
I'm lost on this part.

[brettw, 2009-01-01 23:01:39]

I fixed everything.

http://codereview.chromium.org/16482/diff/19/604
File chrome/renderer/mock_render_thread.h (right):

http://codereview.chromium.org/16482/diff/19/604#newcode22
Line 22: typedef std::pair<IPC::Message, char*> MessagePair;
I fixed the bug where I wasn't deleting this data properly. I was going to
change to some smart object like you suggested, but it would have to be a
linked_ptr<scoped_array<char>> or some object that emulates those properties,
which seemed more trouble than it's worth.

[rvargas (doing something else), 2009-01-05 18:03:16]

LGTM