Issue 16479: Bring up chrome/common/render_mesages.cc on POSIX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16479: Bring up chrome/common/render_mesages.cc on POSIX. (Closed)

Created:
11 years, 12 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
agl, Amanda Walker

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

* Bring up render_mesages.cc on POSIX. * Add Pickle::Read/WriteUint32 & ParamTraits<uint32>. * Removed NSEvent from WebInputEvent since it appears not to be needed anymore.

Patch Set 1 #

Patch Set 2 : also bring up message_router.cc. #

Total comments: 1

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -14 lines)			Patch
M	base/pickle.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	base/pickle.cc	View		1 chunk	+14 lines, -0 lines	1 comment	Download
M	chrome/chrome.xcodeproj/project.pbxproj	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/common.scons	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/ipc_message_utils.h	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	webkit/glue/webinputevent.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	webkit/glue/webinputevent_mac.mm	View		3 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Amanda Walker

11 years, 12 months ago (2008-12-26 22:06:37 UTC) #2

LGTM

http://codereview.chromium.org/16479/diff/209/9
File base/pickle.cc (right):

http://codereview.chromium.org/16479/diff/209/9#newcode147
Line 147: bool Pickle::ReadUInt32(void** iter, uint32* result) const {
we're ending up with a lot of copies of this function differing only in value
type.  Might be useful to just make it into a function template, but I won't
insist for this CL :-).

Expand Messages | Collapse Messages