Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 16477: Mass convert ChromeStaticLibrary -> ChromeLibrary, including pulling the (Closed)

Created:
11 years, 12 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
agl, jeremy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mass convert ChromeStaticLibrary -> ChromeLibrary, including pulling the updated ICU dep that uses it as well. Add a SHARED scons command-line flag to build shared libraries.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -47 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M base/base_lib.scons View 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/base_gfx.scons View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/SConscript View 2 chunks +2 lines, -2 lines 0 comments Download
M build/SConscript.main View 1 chunk +4 lines, -0 lines 0 comments Download
M build/SConscript.v8 View 1 chunk +3 lines, -3 lines 0 comments Download
M build/googleurl_lib.scons View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser.scons View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/debugger.scons View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common.scons View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/util.scons View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin.scons View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer.scons View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation.scons View 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/hunspell/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M gears/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M gears/SConscript.browser View 1 chunk +1 line, -1 line 0 comments Download
M media/media_lib.scons View 1 chunk +1 line, -1 line 0 comments Download
M net/net_lib.scons View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/src/sandbox_lib.scons View 1 chunk +1 line, -1 line 0 comments Download
M sdch/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M skia/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M testing/SConscript.gtest View 1 chunk +1 line, -1 line 0 comments Download
M third_party/bspatch/bspatch.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/bzip2/bzip2.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libevent/libevent.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjpeg/libjpeg.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libpng/libpng.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/libxml.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxslt/libxslt.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/lzma_sdk/lzma_sdk.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/modp_b64/modp_b64.scons View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/zlib.scons View 1 chunk +1 line, -1 line 0 comments Download
M webkit/SConscript.javascriptcore_pcre View 1 chunk +1 line, -1 line 0 comments Download
M webkit/SConscript.port View 1 chunk +1 line, -1 line 0 comments Download
M webkit/activex_shim/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M webkit/build/JavaScriptCore/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M webkit/build/V8Bindings/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M webkit/build/WebCore/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/SConscript View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
I may TBR this as well since everyone is sleeping and it's basically the output ...
11 years, 12 months ago (2008-12-26 04:36:27 UTC) #1
agl
11 years, 12 months ago (2008-12-26 19:09:08 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698