Issue 16467: Add TRACE_EVENT calls to tcp_client_socket_linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16467: Add TRACE_EVENT calls to tcp_client_socket_linux. (Closed)

Created:
12 years ago by dank

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add TRACE_EVENT calls from tcp_client_socket_win.cc into tcp_client_socket_libevent.cc. This was broken out from a larger cl 16027, it's the part you LGTM'd on Dec 23rd. (Should I have just checked this in without a separate review?) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7507

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	net/base/tcp_client_socket_libevent.cc	View	1	10 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

11 years, 11 months ago (2008-12-30 18:40:44 UTC) #2

LGTM

(I think you could have submitted it with a comment referencing the previous
LGTM)

Expand Messages | Collapse Messages