Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 1646008: Fix constant offset check for inlined write barrier to work in cases when off... (Closed)

Created:
10 years, 8 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Fix constant offset check for inlined write barrier to work in cases when offset is given from tagged object pointer. Committed: http://code.google.com/p/v8/source/detail?r=4431

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +11 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
10 years, 8 months ago (2010-04-15 14:18:55 UTC) #1
William Hesse
http://codereview.chromium.org/1646008/diff/1/3 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/1646008/diff/1/3#newcode229 src/x64/macro-assembler-x64.cc:229: // We are storing pointer to an object so ...
10 years, 8 months ago (2010-04-15 14:26:33 UTC) #2
William Hesse
10 years, 8 months ago (2010-04-15 14:35:09 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698