Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: net/base/host_resolver_impl_unittest.cc

Issue 164546: Undisable HostResolverImplTest.EmptyHost, by making empty host fail to resolv... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: reword Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/host_resolver_proc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/host_resolver_impl_unittest.cc
===================================================================
--- net/base/host_resolver_impl_unittest.cc (revision 23412)
+++ net/base/host_resolver_impl_unittest.cc (working copy)
@@ -344,12 +344,7 @@
}
}
-// TODO(eroman): This test is disabled because it is bogus. It used to pass
-// solely because of a bug in the RuleBasedHostMapper -- (empty replacements
-// would map to a failure). However when using the actual host resolver
-// (getaddrinfo), this is not necessarily the case. On windows getaddrinfo("")
-// gives you the address of your machine.
-TEST_F(HostResolverImplTest, DISABLED_EmptyHost) {
+TEST_F(HostResolverImplTest, EmptyHost) {
scoped_refptr<RuleBasedHostResolverProc> resolver_proc =
new RuleBasedHostResolverProc(NULL);
resolver_proc->AllowDirectLookup("*");
« no previous file with comments | « no previous file | net/base/host_resolver_proc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698