Issue 16454: Add pyftpdlib for future ftp unit tests....

Issue 16454: Add pyftpdlib for future ftp unit tests.... (Closed)

Created:
12 years ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Pam (message me for reviews)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add pyftpdlib for future ftp unit tests. From http://codereview.chromium.org/16429/ by contributor ibrar.ahmed@gmail.com TBR=pamg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7427

Patch Set 1 #

Total comments: 2

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10053 lines, -0 lines)			Patch
A	third_party/pyftpdlib/CREDITS	View	1 chunk	+97 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/HISTORY	View	1 chunk	+216 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/INSTALL	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/LICENSE	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/README	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/README.google	View	1 chunk	+12 lines, -0 lines	2 comments	Download
A	third_party/pyftpdlib/build/lib/pyftpdlib/ftpserver.py	View	1 chunk	+3127 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/demo/basic_ftpd.py	View	1 chunk	+44 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/demo/md5_ftpd.py	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/demo/throttled_ftpd.py	View	1 chunk	+89 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/demo/unix_ftpd.py	View	1 chunk	+88 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/demo/winnt_ftpd.py	View	1 chunk	+115 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/doc/adoptions.lnk.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/doc/faq.html	View	1 chunk	+98 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/doc/index.html	View	1 chunk	+158 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/doc/install.html	View	1 chunk	+34 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/doc/release-notes.html	View	1 chunk	+47 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/doc/rfcs-compliance.html	View	1 chunk	+720 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/doc/roadmap.lnk.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/doc/tutorial.html	View	1 chunk	+329 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/pyftpdlib/ftpserver.py	View	1 chunk	+3127 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/setup.py	View	1 chunk	+40 lines, -0 lines	0 comments	Download
A	third_party/pyftpdlib/test/test_ftpd.py	View	1 chunk	+1623 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

11 years, 12 months ago (2008-12-29 18:32:34 UTC) #2

README.google reviewed, LGTM with minor fixes below.  Rubber-stamping the rest
of it.

- Pam

http://codereview.chromium.org/16454/diff/1/21
File third_party/pyftpdlib/README.google (right):

http://codereview.chromium.org/16454/diff/1/21#newcode3
Line 3: For licensing information please LICENSE file
nit: insert "see the"

http://codereview.chromium.org/16454/diff/1/21#newcode5
Line 5: Python FTP server library provides an high-level portable interface to
easily
nit: "an" -> "a"

Expand Messages | Collapse Messages