Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2088)

Unified Diff: chrome/installer/setup/setup_util_unittest.cc

Issue 164537: Renames the function CreateTemporaryFilename to CreateTemporaryFile and track... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: CommandLine fix Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/file_system_accessor_unittest.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup_util_unittest.cc
===================================================================
--- chrome/installer/setup/setup_util_unittest.cc (revision 23574)
+++ chrome/installer/setup/setup_util_unittest.cc (working copy)
@@ -66,8 +66,8 @@
// Test that we are parsing master preferences correctly.
TEST_F(SetupUtilTest, GetInstallPreferencesTest) {
// Create a temporary prefs file.
- std::wstring prefs_file;
- ASSERT_TRUE(file_util::CreateTemporaryFileName(&prefs_file));
+ FilePath prefs_file;
+ ASSERT_TRUE(file_util::CreateTemporaryFile(&prefs_file));
const char text[] =
"{ \n"
" \"distribution\": { \n"
@@ -81,7 +81,8 @@
EXPECT_TRUE(file_util::WriteFile(prefs_file, text, sizeof(text)));
// Make sure command line values override the values in master preferences.
- std::wstring cmd_str(L"setup.exe --installerdata=\"" + prefs_file + L"\"");
+ std::wstring cmd_str(
+ L"setup.exe --installerdata=\"" + prefs_file.value() + L"\"");
cmd_str.append(L" --create-all-shortcuts");
cmd_str.append(L" --do-not-launch-chrome");
cmd_str.append(L" --alt-desktop-shortcut");
« no previous file with comments | « chrome/browser/renderer_host/file_system_accessor_unittest.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698