Issue 1645008: Add tracking of loop nesting to ARM code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1645008: Add tracking of loop nesting to ARM code. (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse

Modified:
10 years, 8 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add tracking of loop nesting to ARM code. Committed: http://code.google.com/p/v8/source/detail?r=4429

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	src/arm/codegen-arm.h	View		3 chunks	+6 lines, -2 lines	0 comments	Download
	M	src/arm/codegen-arm.cc	View		9 chunks	+15 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 8 months ago (2010-04-15 12:46:18 UTC) #2

LGTM

http://codereview.chromium.org/1645008/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1645008/diff/1/2#newcode389
src/arm/codegen-arm.cc:389: loop_nesting_ -= info->loop_nesting();
Seems simpler to ASSERT that loop_nesting() == info->loop_nesting and then set
loop_nesting_ to 0.

http://codereview.chromium.org/1645008/diff/1/2#newcode2091
src/arm/codegen-arm.cc:2091: void
CodeGenerator::VisitForInStatement(ForInStatement* node) {
Wot no loop nesting?

Expand Messages | Collapse Messages