Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: src/handles-inl.h

Issue 164498: Fix strict aliasing crash on x64. (Closed)
Patch Set: remove todo. Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/handles.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 21 matching lines...) Expand all
32 #include "apiutils.h" 32 #include "apiutils.h"
33 #include "handles.h" 33 #include "handles.h"
34 #include "api.h" 34 #include "api.h"
35 35
36 namespace v8 { 36 namespace v8 {
37 namespace internal { 37 namespace internal {
38 38
39 template<class T> 39 template<class T>
40 Handle<T>::Handle(T* obj) { 40 Handle<T>::Handle(T* obj) {
41 ASSERT(!obj->IsFailure()); 41 ASSERT(!obj->IsFailure());
42 location_ = reinterpret_cast<T**>(HandleScope::CreateHandle(obj)); 42 location_ = HandleScope::CreateHandle(obj);
43 } 43 }
44 44
45 45
46 template <class T> 46 template <class T>
47 inline T* Handle<T>::operator*() const { 47 inline T* Handle<T>::operator*() const {
48 ASSERT(location_ != NULL); 48 ASSERT(location_ != NULL);
49 ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue); 49 ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue);
50 return *location_; 50 return *location_;
51 } 51 }
52 52
(...skipping 14 matching lines...) Expand all
67 // Restore state in current handle scope to re-enable handle 67 // Restore state in current handle scope to re-enable handle
68 // allocations. 68 // allocations.
69 v8::ImplementationUtilities::CurrentHandleScope()->extensions = extensions_; 69 v8::ImplementationUtilities::CurrentHandleScope()->extensions = extensions_;
70 } 70 }
71 #endif 71 #endif
72 72
73 73
74 } } // namespace v8::internal 74 } } // namespace v8::internal
75 75
76 #endif // V8_HANDLES_INL_H_ 76 #endif // V8_HANDLES_INL_H_
OLDNEW
« no previous file with comments | « src/handles.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698