Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: src/compilation-cache.cc

Issue 164498: Fix strict aliasing crash on x64. (Closed)
Patch Set: remove todo. Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « SConstruct ('k') | src/handles.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 return Handle<JSFunction>::null(); 283 return Handle<JSFunction>::null();
284 } 284 }
285 } 285 }
286 286
287 287
288 void CompilationCacheScript::Put(Handle<String> source, 288 void CompilationCacheScript::Put(Handle<String> source,
289 Handle<JSFunction> boilerplate) { 289 Handle<JSFunction> boilerplate) {
290 HandleScope scope; 290 HandleScope scope;
291 ASSERT(boilerplate->IsBoilerplate()); 291 ASSERT(boilerplate->IsBoilerplate());
292 Handle<CompilationCacheTable> table = GetTable(0); 292 Handle<CompilationCacheTable> table = GetTable(0);
293 // TODO(X64): -fstrict-aliasing causes a problem with table. Fix it.
294 CALL_HEAP_FUNCTION_VOID(table->Put(*source, *boilerplate)); 293 CALL_HEAP_FUNCTION_VOID(table->Put(*source, *boilerplate));
295 } 294 }
296 295
297 296
298 Handle<JSFunction> CompilationCacheEval::Lookup(Handle<String> source, 297 Handle<JSFunction> CompilationCacheEval::Lookup(Handle<String> source,
299 Handle<Context> context) { 298 Handle<Context> context) {
300 // Make sure not to leak the table into the surrounding handle 299 // Make sure not to leak the table into the surrounding handle
301 // scope. Otherwise, we risk keeping old tables around even after 300 // scope. Otherwise, we risk keeping old tables around even after
302 // having cleared the cache. 301 // having cleared the cache.
303 Object* result = NULL; 302 Object* result = NULL;
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 } 479 }
481 480
482 481
483 void CompilationCache::Disable() { 482 void CompilationCache::Disable() {
484 enabled = false; 483 enabled = false;
485 Clear(); 484 Clear();
486 } 485 }
487 486
488 487
489 } } // namespace v8::internal 488 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « SConstruct ('k') | src/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698