Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: SConstruct

Issue 164498: Fix strict aliasing crash on x64. (Closed)
Patch Set: remove todo. Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compilation-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2008 the V8 project authors. All rights reserved. 1 # Copyright 2008 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 }, 159 },
160 'arch:arm': { 160 'arch:arm': {
161 'CPPDEFINES': ['V8_TARGET_ARCH_ARM'] 161 'CPPDEFINES': ['V8_TARGET_ARCH_ARM']
162 }, 162 },
163 'simulator:arm': { 163 'simulator:arm': {
164 'CCFLAGS': ['-m32'], 164 'CCFLAGS': ['-m32'],
165 'LINKFLAGS': ['-m32'] 165 'LINKFLAGS': ['-m32']
166 }, 166 },
167 'arch:x64': { 167 'arch:x64': {
168 'CPPDEFINES': ['V8_TARGET_ARCH_X64'], 168 'CPPDEFINES': ['V8_TARGET_ARCH_X64'],
169 'CCFLAGS': ['-fno-strict-aliasing', '-m64'], 169 'CCFLAGS': ['-m64'],
170 'LINKFLAGS': ['-m64'], 170 'LINKFLAGS': ['-m64'],
171 }, 171 },
172 'prof:oprofile': { 172 'prof:oprofile': {
173 'CPPDEFINES': ['ENABLE_OPROFILE_AGENT'] 173 'CPPDEFINES': ['ENABLE_OPROFILE_AGENT']
174 } 174 }
175 }, 175 },
176 'msvc': { 176 'msvc': {
177 'all': { 177 'all': {
178 'DIALECTFLAGS': ['/nologo'], 178 'DIALECTFLAGS': ['/nologo'],
179 'CCFLAGS': ['$DIALECTFLAGS', '$WARNINGFLAGS'], 179 'CCFLAGS': ['$DIALECTFLAGS', '$WARNINGFLAGS'],
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
910 # version of scons. Also, there's a bug in some revisions that 910 # version of scons. Also, there's a bug in some revisions that
911 # doesn't allow this flag to be set, so we swallow any exceptions. 911 # doesn't allow this flag to be set, so we swallow any exceptions.
912 # Lovely. 912 # Lovely.
913 try: 913 try:
914 SetOption('warn', 'no-deprecated') 914 SetOption('warn', 'no-deprecated')
915 except: 915 except:
916 pass 916 pass
917 917
918 918
919 Build() 919 Build()
OLDNEW
« no previous file with comments | « no previous file | src/compilation-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698