Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 164482: Restore WebFrame::GetPrintPageShrink() method originally added in rev 14639 (Closed)

Created:
11 years, 4 months ago by Marshall Greenblatt
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Restore the WebFrame::getPrintPageShrink() method originally added in rev 14639 and later removed in rev 19669. From the original commit message: Rev 12100 changed the way that we spool and render printed output, most notably introducing use of the PrintContext class. The existing PrintContext::spoolPage() method applies a webkit scaling factor before rendering output to the graphics context. ChromePrintContext::spoolPage() (in webframe_impl.cc), which is used by chromium instead of PrintContext::spoolPage(), does not apply this scaling factor, but instead eventually returns the scaling factor via WebFrame::PrintPage(). This is a problem for the Chromium Embedded Framework (CEF) because, unlike chromium, the CEF renders directly to the printer device context. It is therefore important for CEF that we retrieve and apply the webkit scaling factor before calling PrintPage(). In order to support this capability the following adds a WebFrame::GetPrintPageShrink() method. BUG=none TEST=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M webkit/api/public/WebFrame.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/webframe_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Marshall Greenblatt
Please review this patch. Original patch set from before WebFrame moved to webkit/api: http://codereview.chromium.org/160004
11 years, 4 months ago (2009-08-13 16:36:03 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/164482/diff/1/2 File webkit/glue/webframe_impl.cc (right): http://codereview.chromium.org/164482/diff/1/2#newcode1050 Line 1050: if (!print_context_.get() || page < 0) { ...
11 years, 4 months ago (2009-08-13 16:57:01 UTC) #2
darin (slow to review)
11 years, 4 months ago (2009-08-13 18:54:25 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698