Issue 164474: Prepare push to trunk to get JSON parser fix into Chromium....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164474: Prepare push to trunk to get JSON parser fix into Chromium.... (Closed)

Created:
11 years, 4 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk to get JSON parser fix into Chromium. Now working on version 1.3.5. Committed: http://code.google.com/p/v8/source/detail?r=2679

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+12 lines, -0 lines	1 comment	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 4 months ago (2009-08-13 12:19:01 UTC) #2

Lgtm

http://codereview.chromium.org/164474/diff/1/3
File ChangeLog (right):

http://codereview.chromium.org/164474/diff/1/3#newcode10
Line 10: Implemented more arithmetic operation optimizations on x64.
I wouldn't mention this.

Expand Messages | Collapse Messages