Issue 164472: X64: Change testl to testb if mask fits in 1 byte. Shortens smi test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164472: X64: Change testl to testb if mask fits in 1 byte. Shortens smi test. (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Change testl to testb if mask fits in 1 byte. Shortens smi test. Committed: http://code.google.com/p/v8/source/detail?r=2680

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/x64/assembler-x64.cc	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/164472/diff/1/2 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/164472/diff/1/2#newcode1611 Line 1611: EnsureSpace ensure_space(this); Move ensure_space below the call ...

11 years, 4 months ago (2009-08-13 12:12:27 UTC) #2

William Hesse

11 years, 4 months ago (2009-08-13 13:55:04 UTC) #3

http://codereview.chromium.org/164472/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/164472/diff/1/2#newcode1611
Line 1611: EnsureSpace ensure_space(this);
On 2009/08/13 12:12:27, Lasse Reichstein wrote:
> Move ensure_space below the call to testb, which has its own ensure_space.

Done.

http://codereview.chromium.org/164472/diff/1/2#newcode1613
Line 1613: if ((mask.value_ & 0xFFFFFF00) == 0) {
On 2009/08/13 12:12:27, Lasse Reichstein wrote:
> Use is_uint8 to test.

Done.

http://codereview.chromium.org/164472/diff/1/2#newcode1631
Line 1631: EnsureSpace ensure_space(this);
On 2009/08/13 12:12:27, Lasse Reichstein wrote:
> Same comments as above.

Done.

Expand Messages | Collapse Messages

Issue 164472: X64: Change testl to testb if mask fits in 1 byte. Shortens smi test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages