Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 164458: Land http://codereview.chromium.org/159067: (Closed)

Created:
11 years, 4 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
tangjie, rafaelw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implementation of getBackgroundPage(), getToolstrips(), and getTabContentses(). This lands http://codereview.chromium.org/159067. Raf, the only thing you need to look at is the changes to extensions_process_bindings.js and extension_api.json. BUG=13577 TEST=Browser tests added Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23422

Patch Set 1 #

Patch Set 2 : 80 cols #

Total comments: 3

Patch Set 3 : rebase #

Patch Set 4 : docs #

Patch Set 5 : docs again #

Patch Set 6 : undo docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -131 lines) Patch
M chrome/browser/extensions/extension_browsertests_misc.cc View 2 chunks +43 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 5 chunks +23 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/common_resources.grd View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 2 3 chunks +47 lines, -20 lines 0 comments Download
M chrome/common/render_messages.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/common/view_types.h View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/bindings_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 2 chunks +59 lines, -15 lines 0 comments Download
M chrome/renderer/render_view.h View 5 chunks +21 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 4 chunks +17 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 1 4 chunks +89 lines, -74 lines 0 comments Download
A chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/backgroundpage.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/test_gettabs.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html View 1 2 2 chunks +29 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip2.html View 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.h View 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
11 years, 4 months ago (2009-08-13 03:12:03 UTC) #1
rafaelw
11 years, 4 months ago (2009-08-13 04:26:24 UTC) #2
lgtm on extension_process_bindings.js & extension_api.json

http://codereview.chromium.org/164458/diff/68/83
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/164458/diff/68/83#newcode51
Line 51: "type": "object"
missing description

http://codereview.chromium.org/164458/diff/68/95
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/164458/diff/68/95#newcode166
Line 166: //   and validating either here, in a unit_test or both.
Can you remove all of these todos while you're here? I did consider the first
(it was too big a pain). The second and third are done.

http://codereview.chromium.org/164458/diff/68/95#newcode186
Line 186: apiFunction.name = apiDef.namespace + "." + functionDef.name;;
Remove second semicolon.

Powered by Google App Engine
This is Rietveld 408576698