Issue 164446: linux: More automation porting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164446: linux: More automation porting. (Closed)

Created:
11 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

linux: More automation porting. I have verified that this is working on Linux, but still have yet to enable any new automated tests. Baby steps. BUG=19076 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23386

Patch Set 1 #

Patch Set 2 : lint #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : automation ipc messages hack fix #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -57 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	1 2	7 chunks	+22 lines, -22 lines	0 comments	Download
M	chrome/browser/automation/ui_controls.h	View	1 2	3 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/automation/ui_controls_linux.cc	View	1 2	3 chunks	+54 lines, -5 lines	0 comments	Download
M	chrome/browser/automation/ui_controls_win.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/blocked_popup_container_interactive_uitest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/views/find_bar_win_interactive_uitest.cc	View	3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/test/automation/automation_messages_internal.h	View	1 2 3 4	3 chunks	+12 lines, -3 lines	1 comment	Download
M	chrome/test/automation/window_proxy.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/automation/window_proxy.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/ui/history_uitest.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

ok I've made some changes in automation_messages_internal, care to review again?

11 years, 4 months ago (2009-08-13 21:06:42 UTC) #3

tony

11 years, 4 months ago (2009-08-13 21:15:20 UTC) #4

LGTM

http://codereview.chromium.org/164446/diff/1054/1055
File chrome/test/automation/automation_messages_internal.h (right):

http://codereview.chromium.org/164446/diff/1054/1055#newcode996
Line 996: #if defined(OS_LINUX) || defined(OS_MACOSX)
Maybe add a short comment here to look above?

Expand Messages | Collapse Messages