Issue 164442: Fix early return/DCHECK importing Safari bookmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164442: Fix early return/DCHECK importing Safari bookmarks. (Closed)

Created:
11 years, 4 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix early return/DCHECK importing Safari bookmarks. BUG=19167 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23250

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	chrome/browser/importer/safari_importer.mm	View		1 chunk	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

11 years, 4 months ago (2009-08-12 23:38:51 UTC) #2

LGTM

Bigger picture it might be nice to have system tests of some kind (e.g. sample
chunks of stuff to try and import, perhaps packaged as a unit test).

Expand Messages | Collapse Messages