Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 164434: Move blocks of build-valgrind-for-chromium.sh around to let it build and use ... (Closed)

Created:
11 years, 4 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, stuartmorgan, dank, the_wrong_timurrrr, Nirnimesh
Visibility:
Public.

Description

Move blocks of build-valgrind-for-chromium.sh around to let it build and use source tarballs, needed for deploying on jailed bots Also change usage message to match last commit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23251

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -58 lines) Patch
M tools/valgrind/build-valgrind-for-chromium.sh View 3 chunks +89 lines, -58 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
dank
Just moving bits around to separate the acts of preparing the source and building it. ...
11 years, 4 months ago (2009-08-12 22:50:58 UTC) #1
Lei Zhang
LGTM http://codereview.chromium.org/164434/diff/1/2 File tools/valgrind/build-valgrind-for-chromium.sh (right): http://codereview.chromium.org/164434/diff/1/2#newcode4 Line 4: # Can also be used to just ...
11 years, 4 months ago (2009-08-12 23:13:27 UTC) #2
dkegel
11 years, 4 months ago (2009-08-12 23:31:49 UTC) #3
On Wed, Aug 12, 2009 at 4:13 PM, <thestig@chromium.org> wrote:
> http://codereview.chromium.org/164434/diff/1/2#newcode4
> Line 4: # Can also be used to just prepare patched source tarball by
> setting MAKE_TARBALL=yes
>>
>> 80 chars per line. Is the presubmit check not nagging about this?

rietvald nags slightly, but the presumbit check doesn't, I think.

Powered by Google App Engine
This is Rietveld 408576698