Issue 164434: Move blocks of build-valgrind-for-chromium.sh around to let it build and use ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164434: Move blocks of build-valgrind-for-chromium.sh around to let it build and use ... (Closed)

Created:
11 years, 4 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, stuartmorgan, dank, the_wrong_timurrrr, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move blocks of build-valgrind-for-chromium.sh around to let it build and use source tarballs, needed for deploying on jailed bots Also change usage message to match last commit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23251

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -58 lines)			Patch
	M	tools/valgrind/build-valgrind-for-chromium.sh	View		3 chunks	+89 lines, -58 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dank

Just moving bits around to separate the acts of preparing the source and building it. ...

11 years, 4 months ago (2009-08-12 22:50:58 UTC) #1

Lei Zhang

LGTM http://codereview.chromium.org/164434/diff/1/2 File tools/valgrind/build-valgrind-for-chromium.sh (right): http://codereview.chromium.org/164434/diff/1/2#newcode4 Line 4: # Can also be used to just ...

11 years, 4 months ago (2009-08-12 23:13:27 UTC) #2

dkegel

11 years, 4 months ago (2009-08-12 23:31:49 UTC) #3

On Wed, Aug 12, 2009 at 4:13 PM, <thestig@chromium.org> wrote:
> http://codereview.chromium.org/164434/diff/1/2#newcode4
> Line 4: # Can also be used to just prepare patched source tarball by
> setting MAKE_TARBALL=yes
>>
>> 80 chars per line. Is the presubmit check not nagging about this?

rietvald nags slightly, but the presumbit check doesn't, I think.

Expand Messages | Collapse Messages