Issue 164433: Send browser crashes to Apple Crash Reporters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164433: Send browser crashes to Apple Crash Reporters. (Closed)

Created:
11 years, 4 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Send browser crashes to Apple Crash Reporters. Send crashes to Apple Crash Reporters so we get a nice UI to restart the Browser process if it crashes. BUG=9231 TEST=Induce a browser crash in a Chrome build, Apple Crash reporter UI should appear aftera few seconds. Induce a renderer crash, no UI should be displayed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23237

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	chrome/app/breakpad_mac.mm	View		2 chunks	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

11 years, 4 months ago (2009-08-12 22:38:25 UTC) #2

LGTM

http://codereview.chromium.org/164433/diff/1/2
File chrome/app/breakpad_mac.mm (right):

http://codereview.chromium.org/164433/diff/1/2#newcode78
Line 78: [breakpad_config setObject:@"NO" forKey:@BREAKPAD_SEND_AND_EXIT];
Are you sure this is @"NO" and not [NSNumber numberWithBool:NO]?

Expand Messages | Collapse Messages