Issue 164418: Mac: Omnibox popup metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164418: Mac: Omnibox popup metrics. (Closed)

Created:
11 years, 4 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Omnibox popup metrics. Use en-dash instead of em-dash to separate match and description. Popup font a little smaller than field font. Make cell taller, and no gap between cells. Use BaseFont from ResourceBundle instead of field's default font (this is what Windows uses, I think). http://crbug.com/19184

Patch Set 1 #

Patch Set 2 : Last-minute changes. #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -9 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	1	2 chunks	+5 lines, -1 line	1 comment	Download
	M	chrome/browser/autocomplete/autocomplete_popup_view_mac.mm	View	1	6 chunks	+26 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 4 months ago (2009-08-12 21:11:48 UTC) #2

LGTM

http://codereview.chromium.org/164418/diff/6/1001
File chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (right):

http://codereview.chromium.org/164418/diff/6/1001#newcode369
Line 369: ResourceBundle::BaseFont).nativeFont();
I didn't see a BaseFont call in AutocompleteEditViewWin, but I notice it in
LocationBarView, so it looks like windows may just abstract differently.

Expand Messages | Collapse Messages