Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 164417: Add git-gs (Closed)

Created:
11 years, 4 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add git-gs

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A git-gs View 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
11 years, 4 months ago (2009-08-12 19:49:53 UTC) #1
tony
LGTM with a nit http://codereview.chromium.org/164417/diff/1/2 File git-gs (right): http://codereview.chromium.org/164417/diff/1/2#newcode7 Line 7: "*SConscript" "SConscript*" "*.scons" "*.vcproj" ...
11 years, 4 months ago (2009-08-12 19:52:18 UTC) #2
M-A Ruel
On 2009/08/12 19:52:18, tony wrote: > LGTM with a nit > > http://codereview.chromium.org/164417/diff/1/2 > File ...
11 years, 4 months ago (2009-08-12 19:55:08 UTC) #3
tony
11 years, 4 months ago (2009-08-12 19:56:45 UTC) #4
On 2009/08/12 19:55:08, Marc-Antoine Ruel wrote:
> On 2009/08/12 19:52:18, tony wrote:
> > LGTM with a nit
> > 
> > http://codereview.chromium.org/164417/diff/1/2
> > File git-gs (right):
> > 
> > http://codereview.chromium.org/164417/diff/1/2#newcode7
> > Line 7: "*SConscript" "SConscript*" "*.scons" "*.vcproj" "*.vsprops"\
> > Nit: I guess we should remove the SCons and vcproj/vsprops extensions now
> since
> > they're not checked into the tree (since git doesn't know about them, git
grep
> > won't search them).
> 
> There are still a few scons (o3d, nacl, etc)

Ah, ok. LGTM

Powered by Google App Engine
This is Rietveld 408576698