Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 164408: Merge 21428 - Allow two user level installs of Chrome to have default browser... (Closed)

Created:
11 years, 4 months ago by Mark Larson
Modified:
9 years, 7 months ago
Reviewers:
kuchhal
CC:
chromium-reviews_googlegroups.com, kuchhal, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 21428 - Allow two user level installs of Chrome to have default browser settings. This change will allow two Windows users to install thier own copy of Chrome and set it as default browser. There is a bunch of refactoring in this change. Divided the registry entries into three categories: * Entries that are only read from HKLM * Entries that actually tie file/protocol associations to Chrome. This will almost always be in HKCU (except when it is a OEM install). * Entries that we can create in HKCU if we fail to create them in HKLM. For single user machine nothing should change. For two users on the same machine (each with a different user level Chrome installed), the second user's default browser will get renamed to Chromium.<user> and the required registry entries will also be renamed so that they do not overwrite first users's registry entries. BUG=3641 TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, userlevel install/systemlevel install. Review URL: http://codereview.chromium.org/159172 TBR=kuchhal@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -397 lines) Patch
MM chrome/browser/shell_integration.cc View 3 chunks +15 lines, -13 lines 0 comments Download
MM chrome/installer/setup/install.cc View 1 chunk +7 lines, -13 lines 0 comments Download
MM chrome/installer/setup/setup_main.cc View 2 chunks +19 lines, -2 lines 0 comments Download
MM chrome/installer/setup/uninstall.h View 3 chunks +6 lines, -4 lines 0 comments Download
MM chrome/installer/setup/uninstall.cc View 6 chunks +28 lines, -4 lines 0 comments Download
MM chrome/installer/util/shell_util.h View 8 chunks +46 lines, -43 lines 0 comments Download
MM chrome/installer/util/shell_util.cc View 12 chunks +394 lines, -315 lines 0 comments Download
MM chrome/installer/util/util_constants.h View 3 chunks +4 lines, -3 lines 0 comments Download
MM chrome/installer/util/util_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Larson
11 years, 4 months ago (2009-08-12 18:25:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698