Issue 164397: - Reduced the maximum capacity of a semi space from 8MB to 4MB....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164397: - Reduced the maximum capacity of a semi space from 8MB to 4MB.... (Closed)

Created:
11 years, 4 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Reduced the maximum capacity of a semi space from 8MB to 4MB. - Changed the semi space growth policy from doubling to increasing by 50%. This slows down V8BenchmarkSuite with 1.32% but reduces the memory footprint with 8MB per V8 instance. Committed: http://code.google.com/p/v8/source/detail?r=2667

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -15 lines)			Patch
M	src/heap.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/spaces.h	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	src/spaces.cc	View	2 chunks	+12 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 4 months ago (2009-08-13 08:45:17 UTC) #3

Drive-by comment.

http://codereview.chromium.org/164397/diff/1/4
File src/spaces.cc (right):

http://codereview.chromium.org/164397/diff/1/4#newcode1079
Line 1079: int extra = capacity_/2;
Just a thought: Would it be safer to round this up to a whole number of (OS)
pages?

Expand Messages | Collapse Messages