Issue 164396: Move some arrays into functions so they don't get cloned on each new context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164396: Move some arrays into functions so they don't get cloned on each new context. (Closed)

Created:
11 years, 4 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Move some arrays into functions so they don't get cloned on each new context. Committed: http://code.google.com/p/v8/source/detail?r=2672

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -72 lines)			Patch
	M	src/messages.js	View		2 chunks	+70 lines, -67 lines	1 comment	Download
	M	src/uri.js	View		3 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 4 months ago (2009-08-12 13:44:47 UTC) #2

LGTM

http://codereview.chromium.org/164396/diff/1/2
File src/messages.js (right):

http://codereview.chromium.org/164396/diff/1/2#newcode36
Line 36: var vowel_mapping = {a: true, e: true, i: true, o: true, u: true, y:
true};
Should we do lazy initialization of these instead as you do for kMessages?

Expand Messages | Collapse Messages