Issue 164393: Add api call to determine whether a string can be externalized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164393: Add api call to determine whether a string can be externalized. (Closed)

Created:
11 years, 4 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add api call to determine whether a string can be externalized. Committed: http://code.google.com/p/v8/source/detail?r=2664

Patch Set 3 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	include/v8.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/api.cc	View	1 2	3 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/164393/diff/5/7 File src/api.cc (right): http://codereview.chromium.org/164393/diff/5/7#newcode3042 Line 3042: i::Handle <i::String> obj = Utils::OpenHandle(this); Should be ...

11 years, 4 months ago (2009-08-12 10:08:04 UTC) #2

Christian Plesner Hansen

11 years, 4 months ago (2009-08-12 10:16:52 UTC) #3

http://codereview.chromium.org/164393/diff/5/7
File src/api.cc (right):

http://codereview.chromium.org/164393/diff/5/7#newcode3042
Line 3042: i::Handle <i::String> obj = Utils::OpenHandle(this);
Right -- this was a cut-and-paste from MakeExternal, I've fixed it in both
places.

Expand Messages | Collapse Messages

Issue 164393: Add api call to determine whether a string can be externalized. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages