Checkpoint for event automation porting....

Checkpoint for event automation porting.

Partially based on patch by Dan Kegel.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23209

[Evan Stade, 2009-08-12 02:54:25]

(new issue)

[tony, 2009-08-12 18:23:23]

Overall, LG, just some nits.

http://codereview.chromium.org/164371/diff/1/2
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/164371/diff/1/2#newcode1734
Line 1734: ui_controls::SendKeyPress(key,
Does this compile on mac?

http://codereview.chromium.org/164371/diff/1/4
File chrome/browser/automation/ui_controls.h (right):

http://codereview.chromium.org/164371/diff/1/4#newcode61
Line 61: #if defined(TOOLKIT_VIEWS)
Can we keep the forward declaration and have this be a stub function on
non-views platforms?  It would get rid of some of the #ifs.

http://codereview.chromium.org/164371/diff/1/9
File chrome/chrome.gyp (right):

http://codereview.chromium.org/164371/diff/1/9#newcode3505
Line 3505: 'tools/build/win/precompiled_wtl.cc',
Does this get compiled on linux?

http://codereview.chromium.org/164371/diff/1/7
File chrome/test/automated_ui_tests/automated_ui_tests.cc (right):

http://codereview.chromium.org/164371/diff/1/7#newcode760
Line 760: return std::wstring();
Nit: NOTIMPLEMENTED()?

[Evan Stade, 2009-08-12 18:54:02]

http://codereview.chromium.org/164371/diff/1/2
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/164371/diff/1/2#newcode1734
Line 1734: ui_controls::SendKeyPress(key,
On 2009/08/12 18:23:23, tony wrote:
> Does this compile on mac?

nope. fixed.

http://codereview.chromium.org/164371/diff/1/4
File chrome/browser/automation/ui_controls.h (right):

http://codereview.chromium.org/164371/diff/1/4#newcode61
Line 61: #if defined(TOOLKIT_VIEWS)
On 2009/08/12 18:23:23, tony wrote:
> Can we keep the forward declaration and have this be a stub function on
> non-views platforms?  It would get rid of some of the #ifs.

Done.

http://codereview.chromium.org/164371/diff/1/9
File chrome/chrome.gyp (right):

http://codereview.chromium.org/164371/diff/1/9#newcode3505
Line 3505: 'tools/build/win/precompiled_wtl.cc',
On 2009/08/12 18:23:23, tony wrote:
> Does this get compiled on linux?

it doesn't seem to mind. Note the ui_tests target also has it.

http://codereview.chromium.org/164371/diff/1/7
File chrome/test/automated_ui_tests/automated_ui_tests.cc (right):

http://codereview.chromium.org/164371/diff/1/7#newcode760
Line 760: return std::wstring();
On 2009/08/12 18:23:23, tony wrote:
> Nit: NOTIMPLEMENTED()?

Done.

[tony, 2009-08-12 19:04:13]

LGTM with one nit

http://codereview.chromium.org/164371/diff/18/21
File chrome/browser/automation/ui_controls.h (right):

http://codereview.chromium.org/164371/diff/18/21#newcode59
Line 59: bool SendMouseClick(MouseButton type);
Nit: Can you add stub functions in ui_controls_linux.cc for the methods that
aren't implemented yet?  The shared object build would need them.