Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1986)

Unified Diff: chrome/common/logging_chrome_uitest.cc

Issue 164352: Reliability test porting: stringy stuff.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: more comments Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/logging_chrome.cc ('k') | chrome/test/perf/mem_usage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome_uitest.cc
===================================================================
--- chrome/common/logging_chrome_uitest.cc (revision 23003)
+++ chrome/common/logging_chrome_uitest.cc (working copy)
@@ -45,8 +45,9 @@
TEST_F(ChromeLoggingTest, LogFileName) {
SaveEnvironmentVariable(std::wstring());
- std::wstring filename = logging::GetLogFileName();
- ASSERT_NE(std::wstring::npos, filename.find(L"chrome_debug.log"));
+ FilePath filename = logging::GetLogFileName();
+ ASSERT_NE(FilePath::StringType::npos,
+ filename.value().find(FILE_PATH_LITERAL("chrome_debug.log")));
RestoreEnvironmentVariable();
}
@@ -55,8 +56,9 @@
TEST_F(ChromeLoggingTest, EnvironmentLogFileName) {
SaveEnvironmentVariable(std::wstring(L"test value"));
- std::wstring filename = logging::GetLogFileName();
- ASSERT_EQ(std::wstring(L"test value"), filename);
+ FilePath filename = logging::GetLogFileName();
+ ASSERT_EQ(FilePath(FILE_PATH_LITERAL("test value")).value(),
+ filename.value());
RestoreEnvironmentVariable();
}
« no previous file with comments | « chrome/common/logging_chrome.cc ('k') | chrome/test/perf/mem_usage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698