Issue 164336: Disk Cache: cleanup of OpenBlockFile....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164336: Disk Cache: cleanup of OpenBlockFile.... (Closed)

Created:
11 years, 4 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
mattm

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Disk Cache: cleanup of OpenBlockFile. Don't add the file to the list of open files until it passes all sanity checks. BUG=18174 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23090

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -7 lines)			Patch
M	net/disk_cache/block_files.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/disk_cache/block_files.cc	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	net/disk_cache/block_files_unittest.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

On 2009/08/11 19:32:32, rvargas wrote:
> 

LGTM