Issue 164332: Use real creator code for Keychain items

Issue 164332: Use real creator code for Keychain items (Closed)

Created:
11 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use real creator code for Keychain items. Instead of hard-coding 'rimZ', use the correct creator code for the application. This is 'rimZ' for branded Google Chrome, and 'Cr24' for Chromium. BUG=19000 TEST=No functional change in Google Chrome-branded builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23074

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -47 lines)			Patch
M	base/mac_util.h	View	1 2 3	3 chunks	+17 lines, -6 lines	0 comments	Download
M	base/mac_util.mm	View	1 2 3	3 chunks	+29 lines, -13 lines	0 comments	Download
M	chrome/browser/importer/importer.cc	View		3 chunks	+10 lines, -13 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac.cc	View	1 2 3	9 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac_internal.h	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_paths.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

http://codereview.chromium.org/164332/diff/1/3 File base/mac_util.h (right): http://codereview.chromium.org/164332/diff/1/3#newcode11 Line 11: #include "base/basictypes.h" This was a mistake, I've removed ...

11 years, 4 months ago (2009-08-11 19:05:44 UTC) #2

stuartmorgan

LGTM http://codereview.chromium.org/164332/diff/21/1005 File chrome/browser/password_manager/password_store_mac_internal.h (right): http://codereview.chromium.org/164332/diff/21/1005#newcode64 Line 64: OSType CreatorCodeForSearch(); This should be private.

11 years, 4 months ago (2009-08-11 19:11:07 UTC) #3

Mark Mentovai

Updated, and added a new #ifdef to chrome_paths.cc.

11 years, 4 months ago (2009-08-11 19:22:27 UTC) #4

LGTM

Expand Messages | Collapse Messages