Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: webkit/glue/webframeloaderclient_impl.cc

Issue 16433: Expand comment for shouldUseCredentialStorage stub, explaining what it might... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include <string> 6 #include <string>
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 10
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 if (d) { 204 if (d) {
205 WebRequestImpl webreq(request); 205 WebRequestImpl webreq(request);
206 d->WillSendRequest(webview, identifier, &webreq); 206 d->WillSendRequest(webview, identifier, &webreq);
207 request = webreq.frame_load_request().resourceRequest(); 207 request = webreq.frame_load_request().resourceRequest();
208 } 208 }
209 } 209 }
210 210
211 bool WebFrameLoaderClient::shouldUseCredentialStorage(DocumentLoader*, 211 bool WebFrameLoaderClient::shouldUseCredentialStorage(DocumentLoader*,
212 unsigned long identifier) { 212 unsigned long identifier) {
213 // FIXME 213 // FIXME
214 // Intended to call a method on the resource load delegate. 214 // Intended to pass through to a method on the resource load delegate.
215 // Returns true for backward compatibility. 215 // If implemented, that method controls whether the browser should ask the
216 // networking layer for a stored default credential for the page (say from
217 // the Mac OS keychain). If the method returns false, the user should be
218 // presented with an authentication challenge whether or not the networking
219 // layer has a credential stored.
220 // This returns true for backward compatibility: the ability to override the
221 // system credential store is new. (Actually, not yet fully implemented in
222 // WebKit, as of this writing.)
216 return true; 223 return true;
217 } 224 }
218 225
219
220 void WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge( 226 void WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge(
221 DocumentLoader*, unsigned long identifier, const AuthenticationChallenge&) { 227 DocumentLoader*, unsigned long identifier, const AuthenticationChallenge&) {
222 // FIXME 228 // FIXME
223 } 229 }
224 230
225 void WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge( 231 void WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge(
226 DocumentLoader*, unsigned long identifier, const AuthenticationChallenge&) { 232 DocumentLoader*, unsigned long identifier, const AuthenticationChallenge&) {
227 // FIXME 233 // FIXME
228 } 234 }
229 235
(...skipping 1263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1493 if (!middle_or_ctrl && !shift && !alt) 1499 if (!middle_or_ctrl && !shift && !alt)
1494 return false; 1500 return false;
1495 1501
1496 DCHECK(disposition); 1502 DCHECK(disposition);
1497 if (middle_or_ctrl) 1503 if (middle_or_ctrl)
1498 *disposition = shift ? NEW_FOREGROUND_TAB : NEW_BACKGROUND_TAB; 1504 *disposition = shift ? NEW_FOREGROUND_TAB : NEW_BACKGROUND_TAB;
1499 else 1505 else
1500 *disposition = shift ? NEW_WINDOW : SAVE_TO_DISK; 1506 *disposition = shift ? NEW_WINDOW : SAVE_TO_DISK;
1501 return true; 1507 return true;
1502 } 1508 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698