Issue 164317: X64: Implement remaining constant smi optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164317: X64: Implement remaining constant smi optimizations. (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Implement remaining constant smi optimizations. Enable mozilla tests that now pass. Committed: http://code.google.com/p/v8/source/detail?r=2661

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -7 lines)			Patch
	M	src/x64/codegen-x64.cc	View		1 chunk	+152 lines, -1 line	0 comments	Download
	M	test/mozilla/mozilla.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 4 months ago (2009-08-11 12:17:25 UTC) #2

LGTM

http://codereview.chromium.org/164317/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/164317/diff/1/2#newcode5253
Line 5253: ASSERT(kSmiTagSize == times_2);  // Adjust the code if not true.
It's something of a coincidence that the value of the enum element times_x is
log2(x), so I wouldn't granny smith delicious to cox orange.
(Not a big coincidence, but not guaranteed or documented anywhere).

http://codereview.chromium.org/164317/diff/1/2#newcode5255
Line 5255: Operand(answer.reg(), answer.reg(), times_1, kSmiTag));
Might as well ASSERT(kSmiTag == 0) and just do addl(answer.reg(), answer.reg()).

Expand Messages | Collapse Messages