Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: src/cfg.cc

Issue 164315: Change the location set size from kPointerSize to kBitsPerPointer.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cfg.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cfg.cc
===================================================================
--- src/cfg.cc (revision 2658)
+++ src/cfg.cc (working copy)
@@ -60,10 +60,10 @@
if (fun->scope()->num_heap_slots() > 0) {
BAILOUT("function has context slots");
}
- if (fun->scope()->num_stack_slots() > kPointerSize) {
+ if (fun->scope()->num_stack_slots() > kBitsPerPointer) {
BAILOUT("function has too many locals");
}
- if (fun->scope()->num_parameters() > kPointerSize - 1) {
+ if (fun->scope()->num_parameters() > kBitsPerPointer - 1) {
BAILOUT("function has too many parameters");
}
if (fun->scope()->arguments() != NULL) {
@@ -320,6 +320,7 @@
if (lhs->AsProperty() != NULL) {
BAILOUT("unsupported property assignment");
}
+
Variable* var = lhs->AsVariableProxy()->AsVariable();
if (var == NULL) {
BAILOUT("unsupported invalid left-hand side");
@@ -333,6 +334,7 @@
BAILOUT("unsupported slot lhs (not a parameter or local)");
}
+ // Parameter and local slot assignments.
ExpressionCfgBuilder builder;
SlotLocation* loc = new SlotLocation(slot->type(), slot->index());
builder.Build(expr->value(), loc);
@@ -361,11 +363,11 @@
ExpressionCfgBuilder object, key;
object.Build(expr->obj(), NULL);
if (object.graph() == NULL) {
- BAILOUT("unsupported object subexpression in propref");
+ BAILOUT("unsupported object subexpression in propload");
}
key.Build(expr->key(), NULL);
if (key.graph() == NULL) {
- BAILOUT("unsupported key subexpression in propref");
+ BAILOUT("unsupported key subexpression in propload");
}
if (destination_ == NULL) destination_ = new TempLocation();
« no previous file with comments | « src/cfg.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698