Issue 164298: Back out r22981, it may have caused Windows test failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164298: Back out r22981, it may have caused Windows test failures. (Closed)

Created:
11 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Back out r22981, it may have caused Windows test failures. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22992

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -283 lines)			Patch
M	build/mac/dump_app_syms	View	2 chunks	+27 lines, -50 lines	0 comments	Download
M	build/mac/tweak_app_infoplist	View	9 chunks	+18 lines, -47 lines	0 comments	Download
M	chrome/app/app-Info.plist	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/plugin_process_host.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	3 chunks	+18 lines, -6 lines	0 comments	Download
M	chrome/browser/utility_process_host.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/worker_host/worker_process_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome.gyp	View	8 chunks	+37 lines, -100 lines	0 comments	Download
M	chrome/common/child_process_host.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/common/child_process_host.cc	View	2 chunks	+0 lines, -65 lines	0 comments	Download

Total messages: 2 (0 generated)

Mark Mentovai

TBR (speculative backout due to redness) This change probably didn't cause the redness after all.

11 years, 4 months ago (2009-08-11 02:23:29 UTC) #1

lgtm