Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4247)

Unified Diff: build/install-build-deps.sh

Issue 164265: Avoid exit due to "-e" and test failure on non-x86_64. (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/install-build-deps.sh
diff --git a/build/install-build-deps.sh b/build/install-build-deps.sh
index 70744fb6096c9808fb7b09daf0390d6af6e6c760..706e937d9eb6a869b8058e8de8939270ec4b2a96 100755
--- a/build/install-build-deps.sh
+++ b/build/install-build-deps.sh
@@ -168,8 +168,10 @@ sudo apt-get update
# without accidentally promoting any packages from "auto" to "manual".
# We then re-run "apt-get" with just the list of missing packages.
echo "Finding missing packages..."
-packages="${dev_list} ${lib_list} ${dbg_list}
- $([ "$(uname -m)" = x86_64 ] && echo ${cmp_list})"
+packages="${dev_list} ${lib_list} ${dbg_list}"
+if [ "$(uname -m)" = x86_64 ]; then
Lei Zhang 2009/08/10 18:53:49 nit: can you put x86_64 in doublequotes?
+ packages+=" ${cmp_list})"
+fi
echo "Packages required: $packages"
new_list_cmd="sudo apt-get install --reinstall $(echo $packages)"
if new_list="$(yes n | LANG=C $new_list_cmd)"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698