Issue 164265: Avoid exit due to "-e" and test failure on non-x86_64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164265: Avoid exit due to "-e" and test failure on non-x86_64. (Closed)

Created:
11 years, 4 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Avoid exit due to "-e" and test failure on non-x86_64.

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	build/install-build-deps.sh	View		1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

11 years, 4 months ago (2009-08-10 18:53:49 UTC) #2

LGTM

http://codereview.chromium.org/164265/diff/1/2
File build/install-build-deps.sh (right):

http://codereview.chromium.org/164265/diff/1/2#newcode172
Line 172: if [ "$(uname -m)" = x86_64 ]; then
nit: can you put x86_64 in doublequotes?

Expand Messages | Collapse Messages